Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2549#discussion_r205048405
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
 ---
    @@ -141,22 +141,52 @@ public 
DictionaryBasedResultCollector(BlockExecutionInfo blockExecutionInfos) {
           }
           fillMeasureData(scannedResult, row);
           if 
(scannedResult.complexParentIndexToQueryMap.toString().contains("StructQueryType"))
 {
    +        int[] isComplexColumn = new int[queryDimensions.length + 
queryMeasures.length];
    +        for (ProjectionDimension dimension : queryDimensions) {
    +          if (null != 
dimension.getDimension().getComplexParentDimension()) {
    +            isComplexColumn[dimension.getOrdinal()] = 1;
    --- End diff --
    
    only checking parent complex dimension. so can we name it 
isComplexChildColumn ?


---

Reply via email to