Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2517#discussion_r205748318
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
 ---
    @@ -724,6 +724,7 @@ public void 
writeLoadDetailsIntoFile(List<SegmentUpdateDetails> listOfSegmentUpd
           brWriter.write(metadataInstance);
         } catch (IOException ioe) {
           LOG.error("Error message: " + ioe.getLocalizedMessage());
    +      fileWrite.setFailed();
    --- End diff --
    
    At some places IO exception is thrown back after setting the flag and some 
places exception is not thrown..any specific reason for this?...can we keep the 
behavior same..better to throw back the exception at all places


---

Reply via email to