[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

[kumarvishal09]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2654#discussion_r214090481
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveDeltaIntegralCodec.java
 ---
    @@ -103,9 +137,33 @@ protected ColumnPageEncoderMeta 
getEncoderMeta(ColumnPage inputPage) {
           protected List<Encoding> getEncodingList() {
             List<Encoding> encodings = new ArrayList<>();
             encodings.add(Encoding.ADAPTIVE_DELTA_INTEGRAL);
    +        if (isInvertedIndex) {
    +          encodings.add(Encoding.INVERTED_INDEX);
    +        }
             return encodings;
           }
     
    +      @Override
    +      protected void fillLegacyFields(DataChunk2 dataChunk) throws 
IOException {
    --- End diff --
    
    can u please move this code to some utility and as below classes also has 
same logic


---