Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2684#discussion_r214619170
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala
 ---
    @@ -81,6 +81,7 @@ class CarbonDataFrameWriter(sqlContext: SQLContext, val 
dataFrame: DataFrame) {
       private def makeCreateTableString(schema: StructType, options: 
CarbonOption): String = {
         val property = Map(
           "SORT_COLUMNS" -> options.sortColumns,
    +      "SORT_SCOPE" -> options.sortScope,
    --- End diff --
    
    From this PR, it seems that carbon will not output error message even if 
there is some table properties it can not recognized during create table by 
DataFrame API. I think it is better to add a check for it.


---

Reply via email to