Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2695#discussion_r215971533
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/carbondata/stream/StreamJobManager.scala
 ---
    @@ -102,14 +107,22 @@ object StreamJobManager {
         }
     
         validateSourceTable(sourceTable)
    -    validateSinkTable(streamDf.schema, sinkTable)
    +
    +    // kafka source always have fixed schema, need to get actual schema
    +    val isKafka = Option(sourceTable.getFormat).exists(_ == "kafka")
    --- End diff --
    
    for string equality, better to use equals


---

Reply via email to