[GitHub] carbondata pull request #2678: [CARBONDATA-2909] Multi user support for SDK ...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2678#discussion_r216207416
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
 ---
    @@ -93,26 +101,19 @@ public static long 
getTableStatusLastModifiedTime(AbsoluteTableIdentifier identi
         }
       }
     
    -  /**
    -   * get valid segment for given table
    -   *
    -   * @return
    -   * @throws IOException
    -   */
       public ValidAndInvalidSegmentsInfo getValidAndInvalidSegments() throws 
IOException {
    -    return getValidAndInvalidSegments(null, null);
    -  }
    -
    -  public ValidAndInvalidSegmentsInfo getValidAndInvalidSegments(
    -      LoadMetadataDetails[] loadMetadataDetails) throws IOException {
    -    return getValidAndInvalidSegments(loadMetadataDetails, null);
    +    if (configuration == null) {
    --- End diff --
    
    Please do this check in the constructor


---