Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2783#discussion_r221237767
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/model/QueryModel.java ---
    @@ -120,7 +121,7 @@
       private boolean isFG;
     
       // whether to clear/free unsafe memory or not
    -  private boolean freeUnsafeMemory = true;
    +  private boolean freeUnsafeMemory;
    --- End diff --
    
    oh, that will need many changes.
    I think it's OK to get this value from system property at the beginning and 
pass the value to the place where it is needed, cause the system property can 
be modified during processing. And in this scenario, directly using system 
property will cause problem.


---

Reply via email to