GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2793
[CARBONDATA-2990] Fixed JVM crash when rebuilding bloom datamap.
Problem: while rebuilding the datamap it access the datamap store so it
builds datamap and store in unsafe onheap storage. But while closing the reader
it frees all memory acquired during that task. Since acquired memory is onheap
but releasing the memory with offheap allocator it crashes the jvm.
Solution: Maintain the type of memory acquired in the memory block itself
and get the allocator as per the memory type and release it.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata
bloom-jvm-crash
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2793.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2793
----
commit bf8f731e21fe9ba0e0a56c75138d72bf87d0d187
Author: ravipesala <ravi.pesala@...>
Date: 2018-09-30T05:57:57Z
Fixed JVM crash when rebuilding bloom datamap.
----
---
