Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2819#discussion_r225792779
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -633,6 +622,56 @@ public boolean getBoolean(int rowId) {
        */
       public abstract double getDouble(int rowId);
     
    +
    +
    +
    +
    +  /**
    +   * Get byte value at rowId
    +   */
    +  public abstract byte[] getByteData();
    --- End diff --
    
    Instead of abstract method better add method with default implemnetion in 
this class, class where we want to provide  the proper implementation we can 
override this method 


---

Reply via email to