Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2829#discussion_r228034556
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ---
    @@ -1845,6 +1845,21 @@
       public static final int CARBON_MINMAX_ALLOWED_BYTE_COUNT_MIN = 10;
       public static final int CARBON_MINMAX_ALLOWED_BYTE_COUNT_MAX = 1000;
     
    +  /**
    +   * Written by detail to be written in carbondata footer for better 
maintanability
    +   */
    +  public static final String CARBON_WRITTEN_BY_FOOTER_INFO = "written_by";
    +
    +  /**
    +   * carbon version detail to be written in carbondata footer for better 
maintanability
    +   */
    +  public static final String CARBON_VERSION_FOOTER_INFO = "version";
    --- End diff --
    
    yes, even this suits better


---

Reply via email to