Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2819#discussion_r228042373
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
 ---
    @@ -66,6 +66,14 @@ public abstract ColumnPageEncoder 
createEncoder(TableSpec.ColumnSpec columnSpec,
        */
       public ColumnPageDecoder createDecoder(List<Encoding> encodings, 
List<ByteBuffer> encoderMetas,
           String compressor) throws IOException {
    +    return createDecoder(encodings, encoderMetas, compressor, false);
    +  }
    +
    +  /**
    +   * Return new decoder based on encoder metadata read from file
    --- End diff --
    
    added comment


---

Reply via email to