[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

[ajantha-bhat]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2869#discussion_r229218201
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/CarbonColumnVectorImpl.java
 ---
    @@ -305,7 +301,7 @@ public void setBlockDataType(DataType blockDataType) {
       }
     
       @Override public CarbonColumnVector getDictionaryVector() {
    -    return dictionaryVector;
    +    return null;
    --- End diff --
    
    should throw unsupported operation exception instead of null ?
    
    or remove the override method itself.


---