Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2874#discussion_r229274712
  
    --- Diff: tools/cli/src/main/java/org/apache/carbondata/tool/DataFile.java 
---
    @@ -500,4 +503,7 @@ private double computePercentage(byte[] data, byte[] 
min, byte[] max, ColumnSche
         }
       }
     
    +  public void close() throws IOException {
    +    this.fileReader.finish();
    --- End diff --
    
    why not close?


---

Reply via email to