Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2869#discussion_r230383031
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AbstractDFSCarbonFile.java
 ---
    @@ -524,6 +524,28 @@ public DataOutputStream 
getDataOutputStreamUsingAppend(String path, FileFactory.
         return getFiles(listStatus);
       }
     
    +  /**
    +   * Method used to list files recursively and apply file filter on the 
result.
    +   *
    +   */
    +  @Override
    +
    +  public List<CarbonFile> listFiles(Boolean recursive, CarbonFileFilter 
fileFilter)
    --- End diff --
    
    `Boolean` is a wrapper class...can you make it primitive and use


---

Reply via email to