Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2863#discussion_r230625603
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveDeltaFloatingCodec.java
 ---
    @@ -244,59 +243,56 @@ public double decodeDouble(long value) {
         }
     
         @Override
    -    public void decodeAndFillVector(ColumnPage columnPage, 
ColumnVectorInfo vectorInfo) {
    +    public void decodeAndFillVector(byte[] pageData, ColumnVectorInfo 
vectorInfo, BitSet nullBits,
    +        DataType pageDataType, int pageSize) {
           CarbonColumnVector vector = vectorInfo.vector;
    -      BitSet nullBits = columnPage.getNullBits();
    -      DataType pageDataType = columnPage.getDataType();
    -      int pageSize = columnPage.getPageSize();
           BitSet deletedRows = vectorInfo.deletedRows;
           DataType vectorDataType = vector.getType();
           vector = ColumnarVectorWrapperDirectFactory
               .getDirectVectorWrapperFactory(vector, null, nullBits, 
deletedRows, true, false);
    +      int k = 0;
    --- End diff --
    
    ok


---

Reply via email to