Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2976#discussion_r240215007
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java
---
@@ -371,9 +374,25 @@ public static CarbonFactDataHandlerModel
getCarbonFactDataHandlerModel(CarbonLoa
.getFormattedCardinality(segmentProperties.getDimColumnsCardinality(),
wrapperColumnSchema);
carbonFactDataHandlerModel.setColCardinality(formattedCardinality);
//TO-DO Need to handle complex types here .
- Map<Integer, GenericDataType> complexIndexMap =
- new HashMap<Integer,
GenericDataType>(segmentProperties.getComplexDimensions().size());
- carbonFactDataHandlerModel.setComplexIndexMap(complexIndexMap);
+
+ int simpleDimensionCount = -1;
+ if (segmentProperties.getDimensions().size() == 0) {
+ simpleDimensionCount = 0;
+ } else {
+ simpleDimensionCount = segmentProperties.getDimensions().size() -
segmentProperties
+ .getNumberOfNoDictionaryDimension() -
segmentProperties.getComplexDimensions().size();
+ }
--- End diff --
Please move down this code to `convertComplexDimensionToGenericDataType`
---
