[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

[ajantha-bhat]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2899#discussion_r241315209
  
    --- Diff: store/CSDK/src/CarbonWriter.cpp ---
    @@ -58,6 +58,35 @@ void CarbonWriter::outputPath(char *path) {
         carbonWriterBuilderObject = 
jniEnv->CallObjectMethodA(carbonWriterBuilderObject, methodID, args);
     }
     
    +void CarbonWriter::sortBy(int argc, char **argv) {
    +    if (argc < 0) {
    +        throw std::runtime_error("argc parameter can't be negative.");
    +    }
    +    if (argv == NULL) {
    +        throw std::runtime_error("argv parameter can't be NULL.");
    +    }
    +    checkBuilder();
    +    jclass carbonReaderBuilderClass = 
jniEnv->GetObjectClass(carbonWriterBuilderObject);
    --- End diff --
    
    it is writerBuilder, not readerBuilder


---