zhxiaoping commented on a change in pull request #3209: [CARBONDATA-3373]
Optimize scenes with in numbers in SQL
URL: https://github.com/apache/carbondata/pull/3209#discussion_r281947085
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
##########
@@ -272,29 +273,21 @@ private BitSet getFilteredIndexesForMeasures(ColumnPage
columnPage,
// Get the measure values from the chunk. compare sequentially with the
// the filter values. The one that matches sets it Bitset.
BitSet bitSet = new BitSet(rowsInPage);
- Object[] filterValues = msrColumnExecutorInfo.getFilterKeys();
-
- SerializableComparator comparator =
Comparator.getComparatorByDataTypeForMeasure(msrType);
+ Set filterValuesSet = msrColumnExecutorInfo.getFilterKeysSet();
BitSet nullBitSet = columnPage.getNullBits();
- for (int i = 0; i < filterValues.length; i++) {
- if (filterValues[i] == null) {
- for (int j = nullBitSet.nextSetBit(0); j >= 0; j =
nullBitSet.nextSetBit(j + 1)) {
- bitSet.set(j);
- }
- continue;
- }
- for (int startIndex = 0; startIndex < rowsInPage; startIndex++) {
- if (!nullBitSet.get(startIndex)) {
- // Check if filterValue[i] matches with measure Values.
- Object msrValue = DataTypeUtil
- .getMeasureObjectBasedOnDataType(columnPage, startIndex,
- msrType, msrColumnEvaluatorInfo.getMeasure());
-
- if (comparator.compare(msrValue, filterValues[i]) == 0) {
- // This is a match.
- bitSet.set(startIndex);
- }
+ for (int startIndex = 0; startIndex < rowsInPage; startIndex++) {
+ if (!nullBitSet.get(startIndex)) {
+ // Check if filterValue[i] matches with measure Values.
+ Object msrValue = DataTypeUtil
+ .getMeasureObjectBasedOnDataType(columnPage, startIndex,
+ msrType, msrColumnEvaluatorInfo.getMeasure());
+
+ if (filterValuesSet.contains(msrValue)) {
Review comment:
I debuged case of decimal and float, if one filed's type is float and one
of values is 123.000 and filter condition is 123.00, in picture's place the
filed's value was converted to 123.0 and filter's value was converted to 123.0,
so they are equal, the decimal is the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
