ravipesala commented on a change in pull request #3245: [CARBONDATA-3398]
Handled show cache for index server and MV
URL: https://github.com/apache/carbondata/pull/3245#discussion_r289284518
##########
File path:
integration/spark2/src/main/scala/org/apache/carbondata/indexserver/DistributedShowCacheRDD.scala
##########
@@ -43,15 +44,25 @@ class DistributedShowCacheRDD(@transient private val ss:
SparkSession, tableName
override def internalCompute(split: Partition, context: TaskContext):
Iterator[String] = {
val dataMaps = DataMapStoreManager.getInstance().getAllDataMaps.asScala
+ val tableList = tableName.split(",")
val iterator = dataMaps.collect {
case (table, tableDataMaps) if table.isEmpty ||
- (tableName.nonEmpty &&
tableName.equalsIgnoreCase(table)) =>
+ (tableName.nonEmpty &&
tableList.contains(table)) =>
val sizeAndIndexLengths = tableDataMaps.asScala
- .map(_.getBlockletDetailsFetcher.getCacheSize)
- // return tableName_indexFileLength_indexCachesize for each executor.
- sizeAndIndexLengths.map {
- x => s"$table:$x"
- }
+ .map { dataMap =>
+ if (!dataMap.getDataMapSchema.getProviderName
+ .equals(DataMapClassProvider.BLOOMFILTER.getShortName)) {
Review comment:
I don't get why we are specifically checking for `BLOOMFILTER`. We are not
supposed to check anything specific
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
