kevinjmh opened a new pull request #3330: [CARBONDATA-3473] Fix data size calcution of the last column in CarbonCli URL: https://github.com/apache/carbondata/pull/3330 when update last column chunk data size, current code use `columnDataSize.add(fileSizeInBytes - footerSizeInBytes - previousChunkOffset)` for every blocklet. This leads to wrong result for calculting the data size of the last column, especially when a carbon data file has multiple blocklet. ``` Scan column 'batchno' | | Blocklet#0: total size 109.77MB, 21 pages, 672,000 rows | | ColumnChunk IO takes 510 us | | Decompress Pages takes 1,018 us | | Blocklet#1: total size 53.96MB, 21 pages, 672,000 rows | | ColumnChunk IO takes 1,570 us | | Decompress Pages takes 1,226 us | | Blocklet#2: total size 37.51KB, 21 pages, 672,000 rows | | ColumnChunk IO takes 584 us | | Decompress Pages takes 1,222 us | ``` In this PR, we fix this problem and modify the calcultion by remarking the end offset of blocklet. Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
