ravipesala commented on a change in pull request #3372: [CARBONDATA-3511] Query
time improvement by reducing the number of NameNode calls while having
carbonindex files in the store
URL: https://github.com/apache/carbondata/pull/3372#discussion_r321220480
##########
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
##########
@@ -64,6 +64,13 @@
*/
private Map<String, Object> segmentLockMap;
+ /**
+ * map of segmentPath to the map of index/ merge index file path to its
+ * corresponding block info. While querying the table this map will be
useful while creating the
+ * block info for the index or merge index file.
+ */
+ private Map<String, Map<String, BlockMetaInfo>> segInfoCache;
Review comment:
Global cache will be risky, how to clean it? Better have a method level
cache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
