jackylk commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r349933813
########## File path: core/src/main/java/org/apache/carbondata/core/util/CustomIndex.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.carbondata.core.util; + +import java.io.ByteArrayInputStream; +import java.io.ByteArrayOutputStream; +import java.io.IOException; +import java.io.ObjectInputStream; +import java.io.ObjectOutputStream; +import java.io.Serializable; +import java.util.Base64; +import java.util.List; +import java.util.Map; + +/** + * Abstract class for custom index handler + * @param <ReturnType> + */ +public abstract class CustomIndex<ReturnType> implements Serializable { + /** + * Initialize the custom index handler instance. + * @param handlerName + * @param properties + * @throws Exception + */ + public abstract void init(String handlerName, Map<String, String> properties) throws Exception; + + /** + * Generates the custom index column value from the given source columns. + * @param columns + * @return Returns generated column value + * @throws Exception + */ + public abstract String generate(List<?> columns) throws Exception; + + /** + * Query processor for custom index handler. + * @param query + * @return Returns list of ranges to be fetched + * @throws Exception + */ + public abstract ReturnType query(String query) throws Exception; + + /** + * Deserializes and returns the custom handler instance + * @param serializedInstance + * @return + * @throws IOException + * @throws ClassNotFoundException + */ + public static CustomIndex getCustomInstance(String serializedInstance) Review comment: Why not implement deserialization in concrete class? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
