jackylk commented on a change in pull request #3571: [CARBONDATA-3659] Fix
issues with alluxio without host and port.
URL: https://github.com/apache/carbondata/pull/3571#discussion_r365520784
##########
File path:
core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java
##########
@@ -198,9 +198,10 @@ private static BlockMetaInfo createBlockMetaInfo(
Set<TableBlockIndexUniqueIdentifier> tableBlockIndexUniqueIdentifiers =
new HashSet<>();
Map<String, String> indexFiles = segment.getCommittedIndexFile();
for (Map.Entry<String, String> indexFileEntry : indexFiles.entrySet()) {
- Path indexFile = new Path(indexFileEntry.getKey());
+ String indexFile = indexFileEntry.getKey();
tableBlockIndexUniqueIdentifiers.add(
- new
TableBlockIndexUniqueIdentifier(indexFile.getParent().toString(),
indexFile.getName(),
+ new TableBlockIndexUniqueIdentifier(indexFile.substring(0,
indexFile.lastIndexOf("/")),
Review comment:
use FileNameUtils from Apache Commons
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
