xuchuanyin commented on a change in pull request #3580: [CARBONDATA-3665]
Support TimeBased Cache expiration using Guava Cache
URL: https://github.com/apache/carbondata/pull/3580#discussion_r368770941
##########
File path:
core/src/main/java/org/apache/carbondata/core/cache/CarbonLRUCache.java
##########
@@ -327,15 +309,15 @@ public Cacheable get(String key) {
*/
public void clear() {
synchronized (lruCacheMap) {
- for (Cacheable cachebleObj : lruCacheMap.values()) {
+ for (Cacheable cachebleObj : lruCacheMap.asMap().values()) {
Review comment:
why not use method `invalidateAll()` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
