jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove
Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage
URL: https://github.com/apache/carbondata/pull/3595#discussion_r372838310
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/TableSpec.java
##########
@@ -103,7 +102,7 @@ private void addDimensions(List<CarbonDimension>
dimensions) {
} else {
noSortNoDictDimSpec.add(spec);
}
- } else if (dimension.isDirectDictionaryEncoding()) {
+ } else if (dimension.getDataType() == DataTypes.DATE) {
spec = new DimensionSpec(ColumnType.DIRECT_DICTIONARY, dimension,
dictActualPosition++);
Review comment:
This is not possible in this PR since DATE is still a direct dictionary,
need to do in another PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
