kunal642 commented on a change in pull request #3600: [CARBONDATA-3678]
optimize list files in insert stage
URL: https://github.com/apache/carbondata/pull/3600#discussion_r375654504
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
##########
@@ -162,6 +163,20 @@ public boolean delete() {
return carbonFiles;
}
+ @Override
+ public CarbonFile[] listFiles(boolean recursive, int maxCount)
+ throws IOException {
+ List<CarbonFile> carbonFiles = new ArrayList<>();
Review comment:
Why not just call the existing listFiles() and ignore the maxCount for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
