ajantha-bhat commented on a change in pull request #3607: [CARBONDATA-3670]
Support compress offheap data in columnpage directly, avoding a copy of data
from offhead to heap before compressed.
URL: https://github.com/apache/carbondata/pull/3607#discussion_r376872535
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/page/SafeFixLengthColumnPage.java
##########
@@ -289,6 +298,15 @@ public BigDecimal getDecimal(int rowId) {
return data;
}
+ @Override
+ public ByteBuffer[] getByteBufferArrayPage(boolean isFlattened) {
Review comment:
The changes was only for offheap data right ? so I expect only unsafe pages
should have changes. Why changed for safe column pages also ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
