akashrn5 commented on a change in pull request #3584: [WIP] Support
SegmentLevel MinMax for better Pruning and less driver memory usage for cache
URL: https://github.com/apache/carbondata/pull/3584#discussion_r379343378
##########
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
##########
@@ -158,6 +171,74 @@ public DataMapBuilder createBuilder(Segment segment,
String shardName,
return dataMaps;
}
+ private void
getTableBlockIndexUniqueIdentifierUsingSegmentPruning(DataMapFilter filter,
+ List<TableBlockIndexUniqueIdentifierWrapper>
tableBlockIndexUniqueIdentifierWrappers,
+ Segment segment, Set<TableBlockIndexUniqueIdentifier> identifiers) {
+ List<SegmentMinMax> segmentMinMaxList = segment.getSegmentMinMax();
+ // boolean isLoadAllIndex =
Boolean.parseBoolean(CarbonProperties.getInstance()
+ //
.getProperty(CarbonCommonConstants.CARBON_LOAD_ALL_INDEX_TO_CACHE,
+ //
CarbonCommonConstants.CARBON_LOAD_ALL_INDEX_TO_CACHE_DEFAULT));
+ if (null != segmentMinMaxList && !filter.isEmpty()) {
Review comment:
i think for filter, you should have null check instead of empty check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
