akashrn5 commented on a change in pull request #3629: [CARBONDATA-3716] Fixed spark 2.4 UT failures URL: https://github.com/apache/carbondata/pull/3629#discussion_r386083590
########## File path: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/binary/TestBinaryDataType.scala ########## @@ -1640,8 +1639,25 @@ class TestBinaryDataType extends QueryTest with BeforeAndAfterAll { | where CUST_ID IS NULL or DOB IS NOT NULL or BIGINT_COLUMN1 =1233720368578 or DECIMAL_COLUMN1 = 12345678901.1234000058 or Double_COLUMN1 = 1.12345674897976E10 or INTEGER_COLUMN1 IS NULL limit 10 """.stripMargin) } - assert(e3.getMessage.contains("cannot resolve 'avg(substring(uniqdata.`CUST_NAME`, 1, 2))' due to data type mismatch: function average requires numeric types, not BinaryType")) - + // Exceptions are specific to spark versions + val message_2_3 = "cannot resolve 'avg(substring(uniqdata.`CUST_NAME`, 1, 2))' due to data type mismatch: function average requires numeric types, not BinaryType" + val message_2_4 = "cannot resolve 'avg(substring(default.uniqdata.`CUST_NAME`, 1, 2))' due to data type mismatch: function average requires numeric types, not binary" + if(SparkUtil.isSparkVersionEqualTo("2.3")) { Review comment: correct the style, can bring to single line ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services