jackylk commented on a change in pull request #3649: [CARBONDATA-3730] Avoid
data conversion and remove duplicate codes in BlockIndexerStorage
URL: https://github.com/apache/carbondata/pull/3649#discussion_r386783042
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorage.java
##########
@@ -50,7 +83,7 @@
*
* @param rowIds
*/
- protected Map<String, short[]> rleEncodeOnRowId(short[] rowIds) {
+ protected void rleEncodeOnRowId(short[] rowIds) {
Review comment:
since you are modifying this, can you change the function name to a more
intuitive name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
