akashrn5 commented on a change in pull request #3659: [CARBONDATA-3738] :
Delete seg. by ID is displaying as failed with invalid ID upon deleting a added
parquet segment.
URL: https://github.com/apache/carbondata/pull/3659#discussion_r397061034
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/DeleteSegmentByIdListener.scala
##########
@@ -49,8 +51,13 @@ class DeleteSegmentByIdListener extends
OperationEventListener with Logging {
val table = metastore
.lookupRelation(Some(carbonTable.getDatabaseName),
tableName)(sparkSession)
.asInstanceOf[CarbonRelation].carbonTable
- CarbonStore
- .deleteLoadById(loadIds, carbonTable.getDatabaseName,
table.getTableName, table)
+ val dataLoadLocation =
CarbonTablePath.getTableStatusFilePath(table.getTablePath)
+ // this check is added to check if the table status file exists or
not. Delete on index
Review comment:
rename `dataLoadLocation` to `tableStatusFilePath` , and please improve the
comment, make it more meaningful to user, because its not index files, its
index table, please update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
