niuge01 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant. URL: https://github.com/apache/carbondata/pull/3661#discussion_r401377408
########## File path: mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/Harmonizer.scala ########## @@ -72,8 +69,8 @@ object HarmonizeDimensionTable extends Rule[ModularPlan] with PredicateHelper { case s@Select(_, _, _, _, jedges, fact :: dims, _, _, _, _) if jedges.forall(e => e.joinType == LeftOuter || e.joinType == Inner) && fact.isInstanceOf[ModularRelation] && - dims.filterNot(_.isInstanceOf[modular.LeafNode]).nonEmpty && - dims.forall(d => (d.isInstanceOf[ModularRelation] || HarmonizedRelation.canHarmonize(d))) => { + !dims.forall(_.isInstanceOf[modular.LeafNode]) && Review comment: OK ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services