ajantha-bhat commented on a change in pull request #3687: [CARBONDATA-3761] Remove redundant conversion for complex type insert URL: https://github.com/apache/carbondata/pull/3687#discussion_r403847723
########## File path: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java ########## @@ -240,141 +238,137 @@ public boolean getIsColumnDictionary() { @Override public void writeByteArray(Object input, DataOutputStream dataOutputStream, Review comment: This part of code is messed up. Need to check and refactor `useActualData` first (which needs some analysis). Without that these flows will be like this ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services