QiangCai commented on a change in pull request #3682: [CARBONDATA-3753]
optimize double/float stats collector
URL: https://github.com/apache/carbondata/pull/3682#discussion_r406015043
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/PrimitivePageStatsCollector.java
##########
@@ -233,20 +233,18 @@ public void update(long value) {
/**
* Return number of digit after decimal point
- * TODO: it operation is costly, optimize for performance
*/
private int getDecimalCount(double value) {
int decimalPlaces = 0;
try {
- String strValue = BigDecimal.valueOf(Math.abs(value)).toPlainString();
- int integerPlaces = strValue.indexOf('.');
- if (-1 != integerPlaces) {
- decimalPlaces = strValue.length() - integerPlaces - 1;
+ BigDecimal decimalValue = BigDecimal.valueOf(value);
Review comment:
better to write code to implement it.
not required to use BigDecimal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
