VenuReddy2103 commented on a change in pull request #3774:
URL: https://github.com/apache/carbondata/pull/3774#discussion_r437700014
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoCommand.scala
##########
@@ -482,6 +490,7 @@ case class CarbonInsertIntoCommand(databaseNameOp:
Option[String],
null
}
var createOrderColumns = table.getCreateOrderColumn.asScala
+ .filterNot(_.getColumnSchema.isSpatialColumn)
Review comment:
Please refer above comment. Also you would want to revisit
`convertToNoDictionaryToBytes()` and
`convertToNoDictionaryToBytesWithoutReArrange()` method in
`InputProcessorStepWithNoConverterImpl` class. Without this PR, length of
`data` and `dataFields` args of those method were not matching as we not
including spatial column. so we had some change in them. With your PR it can be
simplified. Please refer PR #3760.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
