VenuReddy2103 commented on a change in pull request #3896:
URL: https://github.com/apache/carbondata/pull/3896#discussion_r473665479
##########
File path:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
##########
@@ -816,10 +816,20 @@ object CarbonDataRDDFactory {
val partitionByRdd = keyRDD.partitionBy(
new SegmentPartitioner(segmentIdIndex, segmentUpdateParallelism))
+ val conf =
SparkSQLUtil.broadCastHadoopConf(sqlContext.sparkSession.sparkContext,
hadoopConf)
+ val carbonSessionInfo: CarbonSessionInfo = {
Review comment:
Instead of this code block from 820-827lines, could have just used
`carbonSessionInfo = ThreadLocalSessionInfo.getCarbonSessionInfo`
As this object has configuration object within it, i think, it is better to
broadcast and use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
