kunal642 commented on a change in pull request #3861:
URL: https://github.com/apache/carbondata/pull/3861#discussion_r481168720
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala
##########
@@ -824,6 +926,42 @@ class CarbonSecondaryIndexOptimizer(sparkSession:
SparkSession) {
}
}
+ private def checkIfPushDownOrderByLimitAndNotNullFilter(literal: Literal,
sort: Sort,
+ filter: Filter): Boolean = {
+ val filterAttributes = filter.condition collect {
+ case attr: AttributeReference => attr.name.toLowerCase
+ }
+ val parentTableRelation = MatchIndexableRelation.unapply(filter.child).get
+ val matchingIndexTables = CarbonCostBasedOptimizer.identifyRequiredTables(
+ filterAttributes.toSet.asJava,
+
CarbonIndexUtil.getSecondaryIndexes(parentTableRelation).mapValues(_.toList.asJava).asJava)
+ .asScala
+ val databaseName = parentTableRelation.carbonRelation.databaseName
+ // filter out all the index tables which are disabled
+ val enabledMatchingIndexTables = matchingIndexTables
+ .filter(table => {
+ sparkSession.sessionState.catalog
+ .getTableMetadata(TableIdentifier(table,
+ Some(databaseName))).storage
+ .properties
+ .getOrElse("isSITableEnabled", "true").equalsIgnoreCase("true")
+ })
+ // 1. check if only one SI matches for the filter columns
+ if (enabledMatchingIndexTables.nonEmpty && enabledMatchingIndexTables.size
== 1) {
+ // 2. check if all the sort columns is in SI
+ val sortColumns = sort
+ .order
+ .map(_.child.asInstanceOf[AttributeReference].name.toLowerCase())
+ .toSet
+ val indexCarbonTable = CarbonEnv
+ .getCarbonTable(Some(databaseName),
enabledMatchingIndexTables.head)(sparkSession)
+ if (sortColumns.forall { x => indexCarbonTable.getColumnByName(x) !=
null }) {
Review comment:
directly return sortColumns.forall { x =>
indexCarbonTable.getColumnByName(x) != null }
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
