akkio-97 commented on a change in pull request #3906:
URL: https://github.com/apache/carbondata/pull/3906#discussion_r484698276
##########
File path:
integration/hive/src/main/java/org/apache/carbondata/hive/util/DataTypeUtil.java
##########
@@ -21,25 +21,31 @@
import java.util.ArrayList;
import java.util.List;
+import org.apache.carbondata.core.constants.CarbonCommonConstants;
import org.apache.carbondata.core.metadata.datatype.DataType;
import org.apache.carbondata.core.metadata.datatype.DataTypes;
import org.apache.carbondata.core.metadata.datatype.StructField;
+import org.apache.commons.lang.ArrayUtils;
+
public class DataTypeUtil {
public static DataType convertHiveTypeToCarbon(String type) throws
SQLException {
if ("string".equalsIgnoreCase(type) || type.startsWith("char")) {
return DataTypes.STRING;
- } else if ("varchar".equalsIgnoreCase(type)) {
+ } else if (!type.startsWith("map<") && !type.startsWith("array<") &&
!type.startsWith("struct<")
Review comment:
made required changes, they are not required
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
