kunal642 commented on a change in pull request #3913:
URL: https://github.com/apache/carbondata/pull/3913#discussion_r485630147
##########
File path:
integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataSplitManager.java
##########
@@ -117,6 +122,16 @@ public ConnectorSplitSource
getSplits(ConnectorTransactionHandle transactionHand
// file metastore case tablePath can be null, so get from location
location = table.getStorage().getLocation();
}
+ List<PartitionSpec> filteredPartitions = new ArrayList<>();
+ if (layout.getPartitionColumns().size() > 0 &&
layout.getPartitions().isPresent()) {
+ List<String> colNames =
+ layout.getPartitionColumns().stream().map(x -> ((HiveColumnHandle)
x).getName())
+ .collect(Collectors.toList());
+ for (HivePartition partition : layout.getPartitions().get()) {
+ filteredPartitions.add(new PartitionSpec(colNames,
Review comment:
according to this code all the PartitionSpec will have all the column
names!!! is this correct?
The column names in partitionSpec should be per partition right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
