Kejian-Li commented on a change in pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#discussion_r494964396
########## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/TestInsertAndOtherCommandConcurrent.scala ########## @@ -18,34 +18,18 @@ package org.apache.carbondata.spark.testsuite.iud import java.text.SimpleDateFormat -import java.util -import java.util.concurrent.{Callable, ExecutorService, Executors, Future} - -import scala.collection.JavaConverters._ - -import org.apache.hadoop.fs.Path -import org.apache.spark.sql.test.util.QueryTest -import org.apache.spark.sql.types.StructType -import org.apache.spark.sql.{DataFrame, SaveMode} -import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach} import org.apache.carbondata.core.constants.CarbonCommonConstants -import org.apache.carbondata.core.datastore.block.SegmentProperties -import org.apache.carbondata.core.datastore.page.ColumnPage import org.apache.carbondata.core.exception.ConcurrentOperationException -import org.apache.carbondata.core.features.TableOperation -import org.apache.carbondata.core.index.dev.cgindex.{CoarseGrainIndex, CoarseGrainIndexFactory} -import org.apache.carbondata.core.index.dev.{IndexBuilder, IndexWriter} -import org.apache.carbondata.core.index.{IndexInputSplit, IndexMeta, Segment} -import org.apache.carbondata.core.indexstore.PartitionSpec -import org.apache.carbondata.core.metadata.schema.table.{CarbonTable, IndexSchema} -import org.apache.carbondata.core.scan.filter.intf.ExpressionType import org.apache.carbondata.core.util.CarbonProperties -import org.apache.carbondata.events.Event +import org.apache.spark.sql.test.util.QueryTest +import org.apache.spark.sql.types.StructType +import org.apache.spark.sql.{DataFrame, Row, SaveMode} +import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach} Review comment: done ########## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/AsyncExecutorUtils.scala ########## @@ -0,0 +1,200 @@ + + + +package org.apache.carbondata.spark.testsuite.iud Review comment: done ########## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForDeleteCommand.scala ########## @@ -65,7 +65,7 @@ private[sql] case class CarbonProjectForDeleteCommand( s"Unsupported delete operation on table containing mixed format segments") } - if (SegmentStatusManager.isLoadInProgressInTable(carbonTable)) { + if (SegmentStatusManager.isInsertOverwriteInProgress(carbonTable)) { throw new ConcurrentOperationException(carbonTable, "loading", "data delete") Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org