Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495781902
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonCreateMVCommand.scala
##########
@@ -192,9 +192,10 @@ case class CarbonCreateMVCommand(
throw new MalformedCarbonCommandException(
"Cannot create mv on stream table " + table.getTableUniqueName)
}
- if (SegmentStatusManager.isLoadInProgressInTable(table)) {
+ if (SegmentStatusManager.isOverwriteInProgressInTable(table)) {
Review comment:
Create MV While load (LOAD or INSERT INTO) is in progress could also be
allowed, I think, and there is corresponding test to justify it in test class
"TestCreateMVWithTimeSeries", so I changed the method. What's your opinion
aboout it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
