Pickupolddriver commented on a change in pull request #3935:
URL: https://github.com/apache/carbondata/pull/3935#discussion_r504382333
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForDeleteCommand.scala
##########
@@ -108,9 +108,6 @@ private[sql] case class CarbonProjectForDeleteCommand(
}
val executorErrors = ExecutionErrors(FailureCauses.NONE, "")
- // handle the clean up of IUD.
- CarbonUpdateUtil.cleanUpDeltaFiles(carbonTable, false)
Review comment:
Yes, the purpose of PR is to prevent delete data by accident, after
checking the code of `cleanUpDeltaFiles` function, I think it's safe to keep it
here since it will only delete the files in the aborted scenario and it's
crucial for data accuracy. I will revert removing this function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
