akkio-97 commented on a change in pull request #3967:
URL: https://github.com/apache/carbondata/pull/3967#discussion_r504507076
##########
File path:
integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/SliceStreamReader.java
##########
@@ -124,6 +124,17 @@ public void putByteArray(int rowId, int count, byte[]
value) {
}
}
+ @Override
+ public void putAllByteArray(byte[] data, int offset, int length) {
+ int[] lengths = getLengths();
+ int[] offsets = getOffsets();
+ for (int i = 0; i < lengths.length; i++) {
+ if (offsets[i] != 0) {
Review comment:
offset values are 0 by default and put was called, due to which after
select- empty rows were showed. Also select count(*) showed wrong results. Like
you said offset can never be 0, although length may be 0. If offset is 0 then
put should not be called. Hence this check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
