shenjiayu17 commented on a change in pull request #3986: URL: https://github.com/apache/carbondata/pull/3986#discussion_r506020781
########## File path: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonDataMergerUtil.java ########## @@ -1210,6 +1198,39 @@ private static boolean checkDeleteDeltaFilesInSeg(Segment seg, return blockLists; } + private static List<String> checkAndGetDeleteDeltaFilesInSeg(Segment seg, + SegmentUpdateStatusManager segmentUpdateStatusManager, int numberDeltaFilesThreshold) { + + List<String> blockLists = new ArrayList<>(); + + Map<String, List<CarbonFile>> blockAndDeleteDeltaFilesMap = + segmentUpdateStatusManager.getDeleteDeltaFilesForSegment(seg); + + List<String> blockNameList = + segmentUpdateStatusManager.getBlockNameFromSegment(seg.getSegmentNo()); + + Set<String> uniqueBlocks = new HashSet<String>(); + for (final String blockName : blockNameList) { + + List<CarbonFile> deleteDeltaFiles = blockAndDeleteDeltaFilesMap.get(blockName); + + if (null != deleteDeltaFiles) { + for (CarbonFile blocks : deleteDeltaFiles) { Review comment: Done. Added judgement: if (deleteDeltaFiles.size() <= numberDeltaFilesThreshold) continue ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org