ajantha-bhat commented on a change in pull request #3994:
URL: https://github.com/apache/carbondata/pull/3994#discussion_r510987950



##########
File path: 
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
##########
@@ -398,27 +398,29 @@ public static void 
mergeIndexAndWriteSegmentFile(CarbonTable carbonTable, String
    * @throws IOException
    */
   public static String writeSegmentFile(CarbonTable carbonTable, String 
segmentId, String UUID,

Review comment:
       @QiangCai : I have thought about, only non update scenario I can handle 
this issue. For update there is no easy way currently to find out which is 
stale and which is not. One way for update is to read old segment file and add 
files that timestamp greater than old segment file content + old segment file 
content. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to