vikramahuja1001 commented on a change in pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#discussion_r516788672
########## File path: core/src/main/java/org/apache/carbondata/core/util/CleanUtil.java ########## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.carbondata.core.util; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; + +import org.apache.carbondata.common.logging.LogServiceFactory; +import org.apache.carbondata.core.datastore.filesystem.CarbonFile; +import org.apache.carbondata.core.datastore.filesystem.CarbonFileFilter; +import org.apache.carbondata.core.datastore.impl.FileFactory; +import org.apache.carbondata.core.index.IndexStoreManager; +import org.apache.carbondata.core.index.Segment; +import org.apache.carbondata.core.index.TableIndex; +import org.apache.carbondata.core.indexstore.PartitionSpec; +import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier; +import org.apache.carbondata.core.metadata.SegmentFileStore; +import org.apache.carbondata.core.metadata.schema.table.CarbonTable; +import org.apache.carbondata.core.mutate.CarbonUpdateUtil; +import org.apache.carbondata.core.statusmanager.LoadMetadataDetails; +import org.apache.carbondata.core.statusmanager.SegmentStatus; +import org.apache.carbondata.core.statusmanager.SegmentStatusManager; +import org.apache.carbondata.core.statusmanager.SegmentUpdateStatusManager; +import org.apache.carbondata.core.util.path.CarbonTablePath; + +import org.apache.log4j.Logger; + +/** + * Mantains the code used in clean files command, to delete the load folders and move the data + * to trash folder + */ +public final class CleanUtil { + + private static final Logger LOGGER = + LogServiceFactory.getLogService(CarbonUtil.class.getName()); + + public static void physicalFactAndMeasureMetadataDeletion(CarbonTable carbonTable, + LoadMetadataDetails[] newAddedLoadHistoryList, boolean isForceDelete, + List<PartitionSpec> specs) { + LoadMetadataDetails[] currentDetails = + SegmentStatusManager.readLoadMetadata(carbonTable.getMetadataPath()); + physicalFactAndMeasureMetadataDeletion(carbonTable, + currentDetails, + isForceDelete, + specs, + currentDetails); + if (newAddedLoadHistoryList != null && newAddedLoadHistoryList.length > 0) { + physicalFactAndMeasureMetadataDeletion(carbonTable, + newAddedLoadHistoryList, + isForceDelete, + specs, + currentDetails); + } + } + + /** + * Delete the invalid data physically from table. + * @param carbonTable table + * @param loadDetails Load details which need clean up + * @param isForceDelete is Force delete requested by user + * @param specs Partition specs + * @param currLoadDetails Current table status load details which are required for update manager. + */ + private static void physicalFactAndMeasureMetadataDeletion(CarbonTable carbonTable, + LoadMetadataDetails[] loadDetails, boolean isForceDelete, List<PartitionSpec> specs, + LoadMetadataDetails[] currLoadDetails) { + List<TableIndex> indexes = new ArrayList<>(); + try { + for (TableIndex index : IndexStoreManager.getInstance().getAllCGAndFGIndexes(carbonTable)) { + if (index.getIndexSchema().isIndex()) { + indexes.add(index); + } + } + } catch (IOException e) { + LOGGER.warn(String.format( + "Failed to get indexes for %s.%s, therefore the index files could not be cleaned.", + carbonTable.getAbsoluteTableIdentifier().getDatabaseName(), + carbonTable.getAbsoluteTableIdentifier().getTableName())); + } + SegmentUpdateStatusManager updateStatusManager = + new SegmentUpdateStatusManager(carbonTable, currLoadDetails); + for (final LoadMetadataDetails oneLoad : loadDetails) { + if (checkIfLoadCanBeDeletedPhysically(oneLoad, isForceDelete)) { + try { + if (oneLoad.getSegmentFile() != null) { + SegmentFileStore.deleteSegment(carbonTable.getAbsoluteTableIdentifier().getTablePath(), + new Segment(oneLoad.getLoadName(), oneLoad.getSegmentFile()), specs, + updateStatusManager); + } else { + String path = getSegmentPath(carbonTable.getAbsoluteTableIdentifier(), oneLoad); + boolean status = false; + if (FileFactory.isFileExist(path)) { + CarbonFile file = FileFactory.getCarbonFile(path); + CarbonFile[] filesToBeDeleted = file.listFiles(new CarbonFileFilter() { + + @Override + public boolean accept(CarbonFile file) { + return (CarbonTablePath.isCarbonDataFile(file.getName()) || + CarbonTablePath.isCarbonIndexFile(file.getName())); + } + }); + + //if there are no fact and msr metadata files present then no need to keep + //entry in metadata. + if (filesToBeDeleted.length == 0) { + status = true; + } else { + for (CarbonFile eachFile : filesToBeDeleted) { + if (!eachFile.delete()) { + LOGGER.warn("Unable to delete the file as per delete command " + eachFile + .getAbsolutePath()); Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
