Kejian-Li commented on a change in pull request #4004: URL: https://github.com/apache/carbondata/pull/4004#discussion_r530845249
########## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/DeleteExecution.scala ########## @@ -299,37 +279,29 @@ object DeleteExecution { .getDeleteDeltaFilePath(blockPath, blockName, timestamp) val carbonDeleteWriter = new CarbonDeleteDeltaWriterImpl(deleteDeltaPath) - - + segmentUpdateDetails.setSegmentName(segmentId) segmentUpdateDetails.setBlockName(blockName) segmentUpdateDetails.setActualBlockName(completeBlockName) - segmentUpdateDetails.setSegmentName(load.getLoadName) segmentUpdateDetails.setDeleteDeltaEndTimestamp(timestamp) segmentUpdateDetails.setDeleteDeltaStartTimestamp(timestamp) - val alreadyDeletedRows: Long = rowCountDetailsVO.getDeletedRowsInBlock val totalDeletedRows: Long = alreadyDeletedRows + countOfRows segmentUpdateDetails.setDeletedRowsInBlock(totalDeletedRows.toString) - if (totalDeletedRows == rowCountDetailsVO.getTotalNumberOfRows) { - segmentUpdateDetails.setSegmentStatus(SegmentStatus.MARKED_FOR_DELETE) - } Review comment: Why remove if clause? in CarbonUpdateUitl.mergeSegmentUpdate(), line 259 would set blockDetail.setSegmentStatus(newBlockEntry.getSegmentStatus()); ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org