ajantha-bhat commented on a change in pull request #4020:
URL: https://github.com/apache/carbondata/pull/4020#discussion_r531365650
##########
File path:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
##########
@@ -736,11 +738,22 @@ private CarbonCommonConstants() {
@CarbonProperty(dynamicConfigurable = true)
public static final String CARBON_MAJOR_COMPACTION_SIZE =
"carbon.major.compaction.size";
+ /**
+ * Size of Minor Compaction in MBs
+ */
+ @CarbonProperty(dynamicConfigurable = true)
+ public static final String CARBON_MINOR_COMPACTION_SIZE =
"carbon.minor.compaction.size";
+
/**
* By default size of major compaction in MBs.
*/
public static final String DEFAULT_CARBON_MAJOR_COMPACTION_SIZE = "1024";
+ /**
+ * By default size of minor compaction in MBs.
+ */
+ public static final String DEFAULT_CARBON_MINOR_COMPACTION_SIZE = "1048576";
Review comment:
Don't keep default value, I have seen many user's segment more than 1TB.
so for them auto compaction will not work by default. so, I suggest if table
property is configured, then consider size for minor compaction. else the base
behavior like consider all segments based on numbers. Also can support alter
table property
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
