QiangCai commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533026365
########## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ########## @@ -2086,6 +2087,49 @@ public int getMaxSIRepairLimit(String dbName, String tableName) { return Math.abs(Integer.parseInt(thresholdValue)); } + /** + * The below method returns the time(in milliseconds) for which timestamp folder retention in + * trash folder will take place. + */ + public long getTrashFolderRetentionTime() { + long milliSecondsInADay = TimeUnit.DAYS.toMillis(1); + return (long)validateTrashFolderRetentionTime() * milliSecondsInADay; + } + + /** + * The below method returns the time(in days) for which timestamp folder retention in trash + * folder will take place + */ + private int validateTrashFolderRetentionTime() { Review comment: invoke this method in validateAndLoadDefaultProperties ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org