ajantha-bhat commented on a change in pull request #4013:
URL: https://github.com/apache/carbondata/pull/4013#discussion_r534727593
##########
File path:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
##########
@@ -1044,7 +1045,7 @@ public static void cleanSegments(CarbonTable table,
Long fileTimestamp = CarbonUpdateUtil.getTimeStampAsLong(indexFile
.substring(indexFile.lastIndexOf(CarbonCommonConstants.HYPHEN) +
1,
indexFile.length() -
CarbonTablePath.INDEX_FILE_EXT.length()));
- if (CarbonUpdateUtil.isMaxQueryTimeoutExceeded(fileTimestamp) ||
forceDelete) {
+ if (TrashUtil.isTrashDataTimeout(fileTimestamp) || forceDelete) {
Review comment:
Also update this behavior change in document, now
`max.query.execution.time` expire will not delete the data but trash time has
to expire also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
